Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove eosio.system_tests unittests #185

Closed
heifner opened this issue May 21, 2024 · 0 comments · Fixed by #217
Closed

Remove eosio.system_tests unittests #185

heifner opened this issue May 21, 2024 · 0 comments · Fixed by #217
Assignees
Labels
👍 lgtm OCI Work exclusive to OCI team

Comments

@heifner
Copy link
Member

heifner commented May 21, 2024

eosio.system_tests were added back in: AntelopeIO/leap#2054

See the commit comment: 1057d50

Port over some reference contract tests that provide coverage not found in existing unittests. Most of these are likely redundant, but change_inflation, votepay_share_invariant, and votepay_transition2 triggered a producer_double-confirming error no other tests found.

Need to add a test that provides coverage on producer double-confirming error outside of the eosio.system contract tests.

@arhag arhag added 👍 lgtm and removed triage labels May 22, 2024
@arhag arhag added this to the Savanna: Production-Ready milestone May 22, 2024
@heifner heifner self-assigned this May 29, 2024
@heifner heifner added the OCI Work exclusive to OCI team label May 29, 2024
@heifner heifner moved this from Todo to In Progress in Team Backlog May 29, 2024
heifner added a commit that referenced this issue May 29, 2024
@heifner heifner linked a pull request May 29, 2024 that will close this issue
heifner added a commit that referenced this issue May 29, 2024
@heifner heifner closed this as completed Jun 3, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in Team Backlog Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
👍 lgtm OCI Work exclusive to OCI team
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants