Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change INSTANT_FINALITY protocol feature name to SAVANNA #170

Closed
arhag opened this issue May 20, 2024 · 0 comments · Fixed by #211
Closed

Change INSTANT_FINALITY protocol feature name to SAVANNA #170

arhag opened this issue May 20, 2024 · 0 comments · Fixed by #211
Assignees
@heifner
Labels
👍 lgtm OCI Work exclusive to OCI team
Milestone
Savanna: Producti...

Comments

@arhag
Copy link
Member

arhag commented May 20, 2024 •
edited
Loading

Also make all previous protocol features dependencies of the SAVANNA protocol feature.

Make sure the hash is changed to reflect the changes in the comment.
@arhag arhag added this to the Savanna: Production-Ready milestone May 20, 2024
@enf-ci-bot enf-ci-bot moved this to Todo in Team Backlog May 20, 2024
@heifner heifner removed the triage label May 22, 2024
@heifner heifner self-assigned this May 24, 2024
@heifner heifner added the OCI Work exclusive to OCI team label May 24, 2024
@heifner heifner moved this from Todo to In Progress in Team Backlog May 24, 2024
heifner added a commit that referenced this issue May 28, 2024
@heifner
GH-170 Rename instant_finality protocol feature to savanna and make i…
1dbf3d3 
…t depend on all previous protocol features
heifner added a commit that referenced this issue May 28, 2024
@heifner
GH-170 Rename instant_finality protocol feature to savanna
912f41d
heifner added a commit that referenced this issue May 28, 2024
@heifner
GH-170 Update tests for savanna now depending on all previous protoco…
4c61ef9 
…l features
@heifner heifner mentioned this issue May 28, 2024
Merged
@heifner heifner linked a pull request May 28, 2024 that will close this issue
Rename instant_finality protocol feature to savanna #211
Merged
@heifner heifner moved this from In Progress to Awaiting Review in Team Backlog May 28, 2024
heifner added a commit that referenced this issue May 28, 2024
@heifner
GH-170 Add back savanna needed to avoid unresolvable error of set_fin…
456967f 
…alizers
heifner added a commit that referenced this issue May 28, 2024
@heifner
GH-170 Update for all protocol features since savanna now depends on …
d4b2431 
…all of them.
heifner added a commit that referenced this issue May 28, 2024
@heifner
Merge branch 'default_tester' into GH-170-savanna-protocol-feature
a99ca87
heifner added a commit that referenced this issue May 30, 2024
@heifner
Merge branch 'default_tester' into GH-170-savanna-protocol-feature
cd79e82
heifner added a commit that referenced this issue May 31, 2024
@heifner
Merge branch 'default_tester' into GH-170-savanna-protocol-feature
1df48ca
heifner added a commit that referenced this issue Jun 3, 2024
@heifner
Merge remote-tracking branch 'spring/default_tester' into GH-170-sava…
5cb6020 
…nna-protocol-feature
heifner added a commit that referenced this issue Jun 3, 2024
@heifner
Merge remote-tracking branch 'spring/default_tester' into GH-170-sava…
476283d 
…nna-protocol-feature
heifner added a commit that referenced this issue Jun 4, 2024
@heifner
Merge branch 'main' into GH-170-savanna-protocol-feature
71d0dcf
heifner added a commit that referenced this issue Jun 4, 2024
@heifner
Merge pull request #211 from AntelopeIO/GH-170-savanna-protocol-feature
8f65101 
Rename instant_finality protocol feature to savanna
@github-project-automation github-project-automation bot moved this from Awaiting Review to Done in Team Backlog Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@heifner heifner

Labels
👍 lgtm OCI Work exclusive to OCI team
Projects
Team Backlog
Archived in project
Milestone
Savanna: Production-Ready
Development

Successfully merging a pull request may close this issue.

Rename instant_finality protocol feature to savanna AntelopeIO/spring
3 participants
@heifner @arhag @enf-ci-bot