Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a SHiP test for get_blocks_request_v1 across Legacy and Savanna #111

Closed
linh2931 opened this issue May 3, 2024 · 0 comments · Fixed by #114
Closed

Add a SHiP test for get_blocks_request_v1 across Legacy and Savanna #111

linh2931 opened this issue May 3, 2024 · 0 comments · Fixed by #114
Assignees
@linh2931
Labels
👍 lgtm
Milestone
Savanna: Producti...

Comments

@linh2931
Copy link
Member

linh2931 commented May 3, 2024

Start a Nodeos in Legacy. Switch it to Savanna. A ShiP client sends get_blocks_request_v1 requesting from block number 1 to a block number after the transition. Make sure before the transition, finality_data field is always null, and after the transition, it always contains data.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@linh2931 linh2931

Labels
👍 lgtm
Projects
Team Backlog
Archived in project
Milestone
Savanna: Production-Ready
3 participants
@arhag @linh2931 @enf-ci-bot