Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove kv_database_config from snapshot_global_property_object #102

Closed
linh2931 opened this issue May 2, 2024 · 2 comments · Fixed by #109
Closed

Remove kv_database_config from snapshot_global_property_object #102

linh2931 opened this issue May 2, 2024 · 2 comments · Fixed by #109
Assignees
@linh2931
Labels
👍 lgtm
Milestone
Savanna: Producti...

Comments

@linh2931
Copy link
Member

linh2931 commented May 2, 2024 •
edited
Loading

#77 calls for removing kv_database_config from the global_property_object and from the snapshot. It was only removed from global_property_object but not from snapshot_global_property_object by PR #99. Removal from snapshot_global_property_object should be done separately as additional work is required to make sure old snapshots can be loaded.
@linh2931 linh2931 mentioned this issue May 2, 2024
Merged
@heifner
Copy link
Member

heifner commented May 2, 2024

Looks like it was removed: https://github.com/AntelopeIO/spring/pull/99/files#diff-60e9aa15db2886d950de829a0a602fe29fe4e69f28621e45be60e46a51c096a5L75

@linh2931 linh2931 changed the title Remove kv_database_config from the global_property_object and snapshot Remove kv_database_config from snapshots May 2, 2024
@linh2931 linh2931 changed the title Remove kv_database_config from snapshots Remove kv_database_config from snapshot_global_property_object May 2, 2024
@linh2931
Copy link
Member Author

linh2931 commented May 2, 2024

Looks like it was removed: https://github.com/AntelopeIO/spring/pull/99/files#diff-60e9aa15db2886d950de829a0a602fe29fe4e69f28621e45be60e46a51c096a5L75

Thanks. It was removed from global_property_object but not from snapshot_global_property_object. I changed the title.

@linh2931 linh2931 added 👍 lgtm and removed triage labels May 2, 2024
@linh2931 linh2931 self-assigned this May 2, 2024
@linh2931 linh2931 moved this from Todo to In Progress in Team Backlog May 2, 2024
@linh2931 linh2931 mentioned this issue May 3, 2024
Merged
@linh2931 linh2931 moved this from In Progress to Awaiting Review in Team Backlog May 3, 2024
@github-project-automation github-project-automation bot moved this from Awaiting Review to Done in Team Backlog May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@linh2931 linh2931

Labels
👍 lgtm
Projects
Team Backlog
Archived in project
Milestone
Savanna: Production-Ready
Development

Successfully merging a pull request may close this issue.

Remove kv_database_config from snapshots starting in Spring 1.0 (snapshot V7) AntelopeIO/spring
3 participants
@heifner @linh2931 @enf-ci-bot