Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spring 1.0 adds redundant information in log output during replay #1017

Closed
spoonincode opened this issue Nov 7, 2024 · 1 comment · Fixed by #1020
Closed

spring 1.0 adds redundant information in log output during replay #1017

spoonincode opened this issue Nov 7, 2024 · 1 comment · Fixed by #1020
Assignees
Labels
enhancement New feature or request 👍 lgtm

Comments

@spoonincode
Copy link
Member

Prior to spring 1.0 during replay the logs look like,

info  2024-11-07T18:29:33.633 nodeos.50 controller.cpp:528            replay               ] 500 of 402483191
info  2024-11-07T18:29:34.704 nodeos.50 controller.cpp:528            replay               ] 1000 of 402483191
info  2024-11-07T18:29:35.463 nodeos.50 controller.cpp:528            replay               ] 1500 of 402483191
info  2024-11-07T18:29:36.175 nodeos.50 controller.cpp:528            replay               ] 2000 of 402483191
info  2024-11-07T18:29:36.899 nodeos.50 controller.cpp:528            replay               ] 2500 of 402483191
info  2024-11-07T18:29:37.638 nodeos.50 controller.cpp:528            replay               ] 3000 of 402483191

As of spring 1.0 the logs look like

info  2024-11-07T18:28:34.018 nodeos.s1 controller.cpp:1670           replay_block_log     ] 500 of 402483191
info  2024-11-07T18:28:35.024 nodeos.s1 controller.cpp:3637           log_applied          ] Received block ddc03486114e6a1c... #1000 @ 2018-06-09T12:06:33.000 signed by eosio [trxs: 1, lib: 999, net: 10384, cpu: 100495 us, elapsed: 1858 us, applying time: 2049 us, latency: 202458122024 ms]
info  2024-11-07T18:28:35.024 nodeos.s1 controller.cpp:1670           replay_block_log     ] 1000 of 402483191
info  2024-11-07T18:28:35.720 nodeos.s1 controller.cpp:1670           replay_block_log     ] 1500 of 402483191
info  2024-11-07T18:28:36.423 nodeos.s1 controller.cpp:3637           log_applied          ] Received block 206e680a75958c81... #2000 @ 2018-06-09T12:14:53.000 signed by eosio [trxs: 1, lib: 1999, net: 10384, cpu: 99964 us, elapsed: 1958 us, applying time: 2507 us, latency: 202457623423 ms]
info  2024-11-07T18:28:36.423 nodeos.s1 controller.cpp:1670           replay_block_log     ] 2000 of 402483191
info  2024-11-07T18:28:37.134 nodeos.s1 controller.cpp:1670           replay_block_log     ] 2500 of 402483191
info  2024-11-07T18:28:37.850 nodeos.s1 controller.cpp:3637           log_applied          ] Received block 3755ae4c7e9c5751... #3000 @ 2018-06-09T12:23:13.500 signed by eosio [trxs: 1, lib: 2999, net: 10384, cpu: 106037 us, elapsed: 1974 us, applying time: 2162 us, latency: 202457124350 ms]
info  2024-11-07T18:28:37.850 nodeos.s1 controller.cpp:1670           replay_block_log     ] 3000 of 402483191
info  2024-11-07T18:28:38.551 nodeos.s1 controller.cpp:1670           replay_block_log     ] 3500 of 402483191
info  2024-11-07T18:28:39.254 nodeos.s1 controller.cpp:3637           log_applied          ] Received block b7540f01a5ff33f0... #4000 @ 2018-06-09T12:31:34.500 signed by eosio [trxs: 0, lib: 3999, net: 0, cpu: 100 us, elapsed: 20 us, applying time: 39 us, latency: 202456624754 ms]
info  2024-11-07T18:28:39.254 nodeos.s1 controller.cpp:1670           replay_block_log     ] 4000 of 402483191
info  2024-11-07T18:28:39.962 nodeos.s1 controller.cpp:1670           replay_block_log     ] 4500 of 402483191

If we're going to log log_applied during the replay maybe don't log the replay_block_log too (though this will be a very different log output compared to how it has been since eosio 1.0!)

@bhazzard
Copy link

bhazzard commented Nov 7, 2024

Decision to remove log_applied.

@bhazzard bhazzard added enhancement New feature or request 👍 lgtm and removed triage labels Nov 7, 2024
@bhazzard bhazzard added this to the Spring v1.1.0-rc1 milestone Nov 7, 2024
@linh2931 linh2931 self-assigned this Nov 7, 2024
@linh2931 linh2931 moved this from Todo to In Progress in Team Backlog Nov 7, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in Team Backlog Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request 👍 lgtm
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants