Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

syncing, fork database inconsistency on exit #1003

Closed
heifner opened this issue Nov 1, 2024 · 2 comments · Fixed by #1009 or #1012
Closed

syncing, fork database inconsistency on exit #1003

heifner opened this issue Nov 1, 2024 · 2 comments · Fixed by #1009 or #1012
Assignees
@heifner
Labels
bug The product is not working as was intended. 👍 lgtm OCI Work exclusive to OCI team
Milestone
Spring v1.0.4

Comments

@heifner
Copy link
Member

heifner commented Nov 1, 2024 •
edited
Loading

Irreversible does not seem to be advancing when syncing as expected.

info  2024-11-01T12:24:58.288 nodeos    controller.cpp:1842           operator()           ] fork database size 10303 head 397106321 : 17ab5c9177b28ed46be7a7dc2fda570be5dacb5b2d7ff1fc6fcc8b24ec0787cf, root 397096018 : 17ab34527196cd7bb0c0a5a2f25744d6835a34cc45d5a1f886e33726dd7d942a
info  2024-11-01T12:24:58.288 nodeos    controller.cpp:1871           operator()           ] applying 0 fork database blocks from 397106321 to 397106321

The root should be much higher.
@enf-ci-bot enf-ci-bot moved this to Todo in Team Backlog Nov 1, 2024
@heifner
Copy link
Member Author

heifner commented Nov 1, 2024

Verified log_irreversible is being called, something else is going on here. Also repeatable in 1.0.x.

@heifner heifner changed the title 1.1 syncing, fork database on exit syncing, fork database inconsistency on exit Nov 1, 2024
@heifner
Copy link
Member Author

heifner commented Nov 1, 2024

When LIB is ahead of chain head, log_irreversible returns an empty branch from the fork database as it does not find LIB on the head branch.

@heifner heifner added this to the Spring v1.0.4 milestone Nov 1, 2024
@heifner heifner added the bug The product is not working as was intended. label Nov 1, 2024
@heifner heifner self-assigned this Nov 1, 2024
@heifner heifner moved this from Todo to In Progress in Team Backlog Nov 1, 2024
@arhag arhag added 👍 lgtm and removed triage labels Nov 1, 2024
@heifner heifner added the OCI Work exclusive to OCI team label Nov 4, 2024
heifner added a commit that referenced this issue Nov 4, 2024
@heifner
GH-1003 Advance forkdb root when pending lib greater than head
e636de3
@heifner heifner mentioned this issue Nov 4, 2024
Merged
@heifner heifner linked a pull request Nov 4, 2024 that will close this issue
[1.0.4] Advance fork db root when pending lib greater than head #1009
Merged
heifner added a commit that referenced this issue Nov 4, 2024
@heifner
GH-1003 Use forkdb head in irreversible mode
cef8233
heifner added a commit that referenced this issue Nov 4, 2024
@heifner
Merge branch 'release/1.0' into GH-1003-lib
4ed5b76
heifner added a commit that referenced this issue Nov 5, 2024
@heifner
Merge pull request #1009 from AntelopeIO/GH-1003-lib
da6b82f 
[1.0.4] Advance fork db root when pending lib greater than head
heifner added a commit that referenced this issue Nov 5, 2024
@heifner
Merge remote-tracking branch 'spring/release/1.0' into GH-1003-lib-main
0a2e4ec
@heifner heifner mentioned this issue Nov 5, 2024
Merged
heifner added a commit that referenced this issue Nov 5, 2024
@heifner
Merge pull request #1012 from AntelopeIO/GH-1003-lib-main
728b641 
[1.0.4 -> main] Advance fork db root when pending lib greater than head
@github-project-automation github-project-automation bot moved this from In Progress to Done in Team Backlog Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@heifner heifner

Labels
bug The product is not working as was intended. 👍 lgtm OCI Work exclusive to OCI team
Projects
Team Backlog
Status: Done
Milestone
Spring v1.0.4
3 participants
@heifner @arhag @enf-ci-bot