Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split eosio.system_tests.cpp so tests can run in parallel in CICD to reduce overall CICD time #102

Closed
linh2931 opened this issue Jun 12, 2024 · 1 comment · Fixed by #103
Assignees

Comments

@linh2931
Copy link
Member

Currently eosio.system_tests.cpp is 5,921 lines long and takes 5 minutes to run in CICD libtester (https://github.com/AntelopeIO/spring/actions/runs/9468157289/job/26085190747#step:16:984). The next longest test is eosio_system_finalizer_key_unit_test which is about 1 minute. We can split eosio.system_tests.cpp into multiple files (tests) and make each of them run around 1 minute; those tests can run in parallel with other tests. This will reduce libtester running time to about 1 minute, a huge saving without risks, plus smaller files to reduce compilation time if changes are in one small file.

@heifner
Copy link
Member

heifner commented Jun 12, 2024

In addition many of these test produce a large number of blocks for no reason. See changes in AntelopeIO/spring#273
For example:
https://github.com/AntelopeIO/spring/pull/273/files#diff-772ea8af1ac7513dba7209d87abdd10757824ab895a16b9f174f740c17232508L35

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants