Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

After finishing the Knit operation, the FSM should enter state Init not state Ready #173

Closed
t0mpr1c3 opened this issue Oct 18, 2023 · 2 comments · Fixed by #174
Closed

After finishing the Knit operation, the FSM should enter state Init not state Ready #173

t0mpr1c3 opened this issue Oct 18, 2023 · 2 comments · Fixed by #174
Assignees
@t0mpr1c3
Labels
bug ready - please test
Milestone
1.0.0

Comments

@t0mpr1c3
Copy link
Contributor

No description provided.

@t0mpr1c3 t0mpr1c3 added the bug label Oct 18, 2023
@t0mpr1c3 t0mpr1c3 added this to the v1.0 milestone Oct 18, 2023
@t0mpr1c3 t0mpr1c3 self-assigned this Oct 18, 2023
This was referenced Oct 18, 2023
Draft
Merged
@t0mpr1c3 t0mpr1c3 moved this to Needs Testing in AYAB 1.0.0 Release Tracking Feb 25, 2024
@t0mpr1c3 t0mpr1c3 moved this from Needs Testing to Todo in AYAB 1.0.0 Release Tracking Apr 12, 2024
@t0mpr1c3 t0mpr1c3 moved this from Todo to Needs Testing in AYAB 1.0.0 Release Tracking Apr 17, 2024
@X-sam
Copy link
Member

X-sam commented Jul 29, 2024

Is this related to AllYarnsAreBeautiful/ayab-desktop#577

@jonathanperret
Copy link
Contributor

@X-sam I'd say they're not really related. AllYarnsAreBeautiful/ayab-desktop#577 is about canceling, whereas this issue is about the normal end of knitting, and the linked PR (#174) changes the Knitter::stopKnitting method which is only called at the end of a complete knitting run.

In any case #174 does make the change requested here, I think this can be closed.

@github-project-automation github-project-automation bot moved this from Needs Testing to Done in AYAB 1.0.0 Release Tracking Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@t0mpr1c3 t0mpr1c3

Labels
bug ready - please test
Projects
AYAB 1.0.0 Release Tracking
Status: Done
Milestone
1.0.0
Development

Successfully merging a pull request may close this issue.

Move to state Init after finishing Knit operation t0mpr1c3/ayab-firmware
3 participants
@jonathanperret @t0mpr1c3 @X-sam