Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possibly a issue with the command migrate_static_placeholders doesn't replace template load tags #4

Open
Aiky30 opened this issue Apr 6, 2022 · 3 comments

Comments

@Aiky30
Copy link
Owner

Aiky30 commented Apr 6, 2022

No description provided.

@vinitkumar
Copy link

The migration script tries to replace usage of {% load cms %} with {% load cms djangocms_alias_tags %}, which might work in some cases, but fails with templates which have the multiple loads in one line.

{% load cms_tags i18n ... %}

This happens with us since we use multiple loads in one line.

@Aiky30
Copy link
Owner Author

Aiky30 commented Apr 7, 2022

Thanks @vinitkumar, the current search is: "{% load cms_tags" I'll try and put something together that doesn't look for cms_tags. Also there's no test suite for this package. I'll look at adding any fixes new features with one. It was seen as the migration is one big test and was hard to justify creating tests historically, that is different for the community.

@Aiky30
Copy link
Owner Author

Aiky30 commented Apr 7, 2022

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants