Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

contextData should accept JSON properties #16

Open
marcus-robinson opened this issue Jun 9, 2020 · 1 comment
Open

contextData should accept JSON properties #16

marcus-robinson opened this issue Jun 9, 2020 · 1 comment

Comments

@marcus-robinson
Copy link

marcus-robinson commented Jun 9, 2020

As it stands, the contextData property forces the developer to provide values as XML, like this:

var callData = { pageName: 'analytics-di-test', visitorID: 'myvisitorId123123123123', contextData: '<sc_contextDataTest>my context data test</sc_contextDataTest>' };

It is very confusing for a Node library to ask developers to provide XML strings. JSON is the object notation for JavaScript and it should be the library's job to convert a developer's context data JSON object into the required XML string that the AA API expects, instead of putting this burden on the developer.

@davidbenge
Copy link
Contributor

much better idea
way more natural

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants