Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PE-D][Tester D] Application Mismanages Phone Numbers Containing Non-Numeric Characters #192

Closed
nus-se-script opened this issue Apr 5, 2024 · 1 comment
Assignees
Labels
feature suggestion Features that improves the ease of use or the quality of life for the user severity.Medium A flaw that causes occasional inconvenience to some users but they can continue to use the product. wontfix This will not be worked on

Comments

@nus-se-script
Copy link

Description:
The application fails to recognize common phone number conventions that include descriptors such as "(office)", "(home)", etc. These are commonly used formats and should be accepted by the application.

Steps to Reproduce:

Launch the application.
Attempt to add a new contact with a phone number descriptor using the command: add n/John Doe p/98765432 (office) e/[email protected] m/CS2103 f/Computing v/311, Clementi Ave 2, #2-25 t/friends t/owesMoney a/mon 12:00 14:00 a/thur 12:00 14:00.
Expected Result:

The contact should be added successfully with the phone number including the descriptor "(office)".
Actual Result:

The application rejects the command with an error message: "Phone numbers should only contain numbers, and it should be at least 3 digits long."
Severity:

Medium: This limitation can inconvenience users who use phone number descriptors for better organization and clarity, leading to possible avoidance of using the application for managing contacts.
Screenshots:

Suggestion:

Adjust the application's phone number validation logic to accept these common phone number formats with descriptors. This would likely involve changes to both the back-end validation and the user guide documentation to explicitly state that such formats are supported.

Screenshot 2024-04-05 at 5.26.52 PM.png


Labels: severity.Medium type.FunctionalityBug
original: Shauryan123/ped#7

@whitesnowx whitesnowx self-assigned this Apr 11, 2024
@whitesnowx whitesnowx added severity.Low A flaw that is unlikely to affect normal operations of the product. Minor inconvenience only. not allowed to fix Bugs that are not allowed to be fix in v1.4 type.Enhancement An enhancement to an existing story labels Apr 11, 2024
@whitesnowx
Copy link
Collaborator

Intentional Design: Phone Descriptor not need for our purpose

Followup: #233

  • Include Plausible Workaround

@whitesnowx whitesnowx added feature suggestion Features that improves the ease of use or the quality of life for the user wontfix This will not be worked on and removed type.Enhancement An enhancement to an existing story severity.Low A flaw that is unlikely to affect normal operations of the product. Minor inconvenience only. not allowed to fix Bugs that are not allowed to be fix in v1.4 labels Apr 11, 2024
@whitesnowx whitesnowx added the severity.Medium A flaw that causes occasional inconvenience to some users but they can continue to use the product. label Apr 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature suggestion Features that improves the ease of use or the quality of life for the user severity.Medium A flaw that causes occasional inconvenience to some users but they can continue to use the product. wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants