overlays builds pipeline fails when using Issue Deliver Container Image

[pacospace]

Describe the bug
Overlays build pipeline fails when run from issue pipeline.

To Reproduce
Steps to reproduce the behavior:

1. Open Issue with Deliver Container Image in Elyra tutorial and see pipeline failing.

Expected behavior
Pipeline successfully delivers all overlays builds.

Screenshots

Additional context

[pacospace]

I did some debugging, and it seems base image is not passed to later step. In particular when opening issue for Delivering Container Image the first step to handle configuration does not consider overlays, therefore later steps miss inputs, like base image:

We can see error in generate task:

+ '[' -z '' ']'
+ '[' -f Dockerfile ']'
+ '[' -f Containerfile ']'
+ /usr/local/bin/s2i build . --env THAMOS_RUNTIME_ENVIRONMENT= --env THOTH_ADVISE=0 --env THOTH_ERROR_FALLBACK=1 --env THOTH_DRY_RUN=1 --env THAMOS_DEBUG=0 --env THAMOS_VERBOSE=1 --env THOTH_PROVENANCE_CHECK=0 --loglevel=0 --as-dockerfile /gen-source/Containerfile
ERROR: Required value not specified for "builderImage"

and step later fails to give a misleading error, because in reality the ContainerFile has not been created by the previous task

+ buildah bud --storage-driver=overlay --tls-verify=false --layers -f /gen-source/Containerfile -t elyra-aidevsecops-tutorial-166 .
stat /gen-source/Containerfile: no such file or directory

[goern]

/kind bug
/priority critical-urgent
/assign @harshad16

[harshad16]

FIxed it with b4f842a
closing it, please reopen if the issue persists.

[pacospace]

@harshad16 does it solve also the overlays build issue when using "Deliver Container Image" issue?

[harshad16]

no it doesnt , let me re-open this.

[goern]

Blocking: thoth-station/ps-cv#2
Blocking: thoth-station/ps-nlp#3

[pacospace]

Blocking: thoth-station/ps-cv#2
Blocking: thoth-station/ps-nlp#3

Not blocking those, this issue is when someone uses issue Deliver Container Image with overlays builds

[goern]

ACK, thx.

[goern]

is this still valid?

[sesheta]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

/lifecycle stale

[sesheta]

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

/lifecycle rotten

[harshad16]

yes this is still valid
will get this on lifecycle soon
/lifecycle frozen