From f17b1023cd1638541524a7f2e0cb55bb7a1f33c4 Mon Sep 17 00:00:00 2001
From: Amadeusz Sadowski <amis.tau.92@gmail.com>
Date: Wed, 8 Apr 2020 12:27:54 +0200
Subject: [PATCH] feat: Additional Metapackage settings

- added IncludeSymbols=false, fixes #220
- added IncludeBuildOutput=false
- moved UsingCodeGenerationRoslynToolTargets=true to build/.props
---
 README.md                                                    | 3 ---
 .../MetapackageSample/MetapackageSample.csproj               | 4 ----
 .../Sdk/Sdk.props                                            | 2 --
 .../build/CodeGeneration.Roslyn.PluginMetapackage.Sdk.props  | 5 +++++
 .../SourceGenerator/SourceGenerator.csproj                   | 1 -
 5 files changed, 5 insertions(+), 10 deletions(-)

diff --git a/README.md b/README.md
index 42b4a3482..db8e261de 100644
--- a/README.md
+++ b/README.md
@@ -484,7 +484,6 @@ Remove `Class1.cs` file.
 
 Modify project file:
 - Add `<Sdk>` element
-- Set `IncludeBuildOutput=false`
 - Add `NupkgAdditionalDependency` in ItemGroup
 ```xml
 <!-- Duplicator/Duplicator.csproj -->
@@ -495,8 +494,6 @@ Modify project file:
   <PropertyGroup>
     <!-- Declare the TargetFramework(s) the same as in your Attributes package -->
     <TargetFramework>netstandard1.0</TargetFramework>
-    <!-- We don't want any build output in package -->
-    <IncludeBuildOutput>false</IncludeBuildOutput>
   </PropertyGroup>
 
   <ItemGroup>
diff --git a/samples/MetapackageSample/MetapackageSample/MetapackageSample.csproj b/samples/MetapackageSample/MetapackageSample/MetapackageSample.csproj
index 637cd1a6a..7d25ab456 100644
--- a/samples/MetapackageSample/MetapackageSample/MetapackageSample.csproj
+++ b/samples/MetapackageSample/MetapackageSample/MetapackageSample.csproj
@@ -12,10 +12,6 @@
   <PropertyGroup>
     <!-- Declare the TargetFramework(s) the same as in your Attributes package -->
     <TargetFrameworks>netstandard1.0;netstandard2.0</TargetFrameworks>
-    <!-- This project contains no files, so building can be skipped -->
-    <NoBuild>true</NoBuild>
-    <!-- Since we don't build, there'll be no build output -->
-    <IncludeBuildOutput>false</IncludeBuildOutput>
   </PropertyGroup>
 
   <ItemGroup>
diff --git a/src/CodeGeneration.Roslyn.PluginMetapackage.Sdk/Sdk/Sdk.props b/src/CodeGeneration.Roslyn.PluginMetapackage.Sdk/Sdk/Sdk.props
index 14bd395af..e78f4f12f 100644
--- a/src/CodeGeneration.Roslyn.PluginMetapackage.Sdk/Sdk/Sdk.props
+++ b/src/CodeGeneration.Roslyn.PluginMetapackage.Sdk/Sdk/Sdk.props
@@ -5,8 +5,6 @@
     <!-- Announce this SDK (add *AsSdk to differentiate between using this as Sdk
       and normal PackageReference/dependency usage)-->
     <UsingCodeGenerationRoslynPluginMetapackageSdkAsSdk>true</UsingCodeGenerationRoslynPluginMetapackageSdkAsSdk>
-    <!-- Prevent running Tool targets in metapackage -->
-    <UsingCodeGenerationRoslynToolTargets>false</UsingCodeGenerationRoslynToolTargets>
   </PropertyGroup>
 
   <Import Project="../build/CodeGeneration.Roslyn.PluginMetapackage.Sdk.props" />
diff --git a/src/CodeGeneration.Roslyn.PluginMetapackage.Sdk/build/CodeGeneration.Roslyn.PluginMetapackage.Sdk.props b/src/CodeGeneration.Roslyn.PluginMetapackage.Sdk/build/CodeGeneration.Roslyn.PluginMetapackage.Sdk.props
index 225a0cd5b..0243be013 100644
--- a/src/CodeGeneration.Roslyn.PluginMetapackage.Sdk/build/CodeGeneration.Roslyn.PluginMetapackage.Sdk.props
+++ b/src/CodeGeneration.Roslyn.PluginMetapackage.Sdk/build/CodeGeneration.Roslyn.PluginMetapackage.Sdk.props
@@ -4,6 +4,11 @@
   <PropertyGroup>
     <!-- Announce this SDK -->
     <UsingCodeGenerationRoslynPluginMetapackageSdk>true</UsingCodeGenerationRoslynPluginMetapackageSdk>
+    <!-- Prevent running Tool targets in metapackage -->
+    <UsingCodeGenerationRoslynToolTargets>false</UsingCodeGenerationRoslynToolTargets>
+    <!-- Setup so that by default no build output and no symbols are packed -->
+    <IncludeBuildOutput>false</IncludeBuildOutput>
+    <IncludeSymbols>false</IncludeSymbols>
   </PropertyGroup>
 
   <!--
diff --git a/templates/content/SourceGenerator.MetapackageProjects/SourceGenerator/SourceGenerator.csproj b/templates/content/SourceGenerator.MetapackageProjects/SourceGenerator/SourceGenerator.csproj
index 0a1c37041..e0f336e31 100644
--- a/templates/content/SourceGenerator.MetapackageProjects/SourceGenerator/SourceGenerator.csproj
+++ b/templates/content/SourceGenerator.MetapackageProjects/SourceGenerator/SourceGenerator.csproj
@@ -7,7 +7,6 @@
 
   <PropertyGroup>
     <TargetFramework>netstandard1.0</TargetFramework>
-    <IncludeBuildOutput>false</IncludeBuildOutput>
   </PropertyGroup>
 
   <ItemGroup>