Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Controlling feature availability #589

Closed
1 task done
jeffpaul opened this issue Oct 16, 2023 · 4 comments · Fixed by #614
Closed
1 task done

Controlling feature availability #589

jeffpaul opened this issue Oct 16, 2023 · 4 comments · Fixed by #614
Assignees
Milestone

Comments

@jeffpaul
Copy link
Member

Is your enhancement related to a problem? Please describe.

Most features have the ability to enable/disable them directly within their Setup/Settings pages on a binary sitewide basis, but in cases where specific features do not have a toggle one will be added to ensure that you can enable/disable each individual feature on each site via the admin UI. We should also ensure that all features can be enabled/disabled via hooks so that you could have an MU plugin that sets site-wide defaults for feature availability.

From a high-level estimation perspective, this will likely be a rather straightforward effort (“t-shirt sized” S) and feasibly completed within 1-3 days.

Designs

n/a

Describe alternatives you've considered

n/a

Code of Conduct

  • I agree to follow this project's Code of Conduct
@jeffpaul jeffpaul added this to the 2.5.0 milestone Oct 16, 2023
@jeffpaul jeffpaul self-assigned this Oct 16, 2023
@jeffpaul jeffpaul moved this from Incoming to To Do in Open Source Practice Oct 16, 2023
@ravinderk ravinderk self-assigned this Oct 23, 2023
@ravinderk
Copy link
Contributor

We should also ensure that all features can be enabled/disabled via hooks so that you can have an MU plugin that sets site-wide defaults for feature availability.

@jeffpaul In this case, we should display a message (non-dismissable) to an admin about settings that can not be changed on setting pages. What do you think?

cc: @dkotter

@ravinderk
Copy link
Contributor

Most features have the ability to enable/disable them directly within their Setup/Settings pages on a binary sitewide basis, but in cases where specific features do not have a toggle, one will be added to ensure that you can enable/disable each individual feature on each site via the admin UI

@dkotter I visited the ClassIfAI plugin settings, and In my opinion, we have settings for most features. I did not see the requirement of adding a toggle setting for AI features. I will continue to work on implementing filter hooks to toggle settings programmatically.

Let me know if I miss anything.

@jeffpaul
Copy link
Member Author

@jeffpaul In this case, we should display a message (non-dismissable) to an admin about settings that can not be changed on setting pages. What do you think?

Let's not worry about that. If someone creates an MU plugin that blocks certain things, then that could include an admin notice if useful for their site.

@jeffpaul In this case, we should display a message (non-dismissable) to an admin about settings that can not be changed on setting pages. What do you think?

I'm not seeing an enable/disable toggle for:

  • Language Processing / IBM Watson / Natural Language Understanding
  • Language Processing / Microsoft Azure / Text to Speech
  • Recommended Content / Microsoft Azure / AI Personalizer

@jeffpaul jeffpaul assigned iamdharmesh and unassigned ravinderk and jeffpaul Nov 3, 2023
@jeffpaul jeffpaul moved this from To Do to In Progress in Open Source Practice Nov 6, 2023
@jeffpaul jeffpaul modified the milestones: 2.5.0, 2.4.0 Nov 6, 2023
@dkotter dkotter modified the milestones: 2.4.0, 2.5.0 Nov 7, 2023
@iamdharmesh iamdharmesh linked a pull request Nov 10, 2023 that will close this issue
4 tasks
@iamdharmesh iamdharmesh moved this from In Progress to In Review in Open Source Practice Nov 10, 2023
@iamdharmesh
Copy link
Member

@jeffpaul we can close this as this is already implemented and merged in #614

cc: @dkotter

@dkotter dkotter closed this as completed Nov 22, 2023
@github-project-automation github-project-automation bot moved this from In Review to Merged in Open Source Practice Nov 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants